I2C Rust #3
Merged
I2C Rust #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvyuemeng
added
enhancement
bcm2835_rust: continue Add functions Caution: the problem of dev.msg_buf and curr_msg.buf is needed to be reconciled i2c: Add basic structure for ffi bindings. Signed-off-by: Nostalgia <[email protected]>
bcm2835_rust: continue Add functions Caution: the problem of dev.msg_buf and curr_msg.buf, we need to consruct a elegant way for a replacement of ptr++ . Signed-off-by: Nostalgia <[email protected]>
bcm2835_rust: continue Add functions Caution: the problem of dev.msg_buf and curr_msg.buf, we need to consruct a elegant way for a replacement of ptr++ . Signed-off-by: Nostalgia <[email protected]>
Add bcm2835_i2c_xfer Add Error: EREMOTEIO Add bcm2835_i2c_func Signed-off-by: Nostalgia <[email protected]>
Add bcm2835_i2c_xfer Add Error: EREMOTEIO Add bcm2835_i2c_func Signed-off-by: Nostalgia <[email protected]>
bcm2835_rust: 部分修正，尝试填充probe函数。 i2c mod: 添加i2c_quirks。 Signed-off-by: Nostalgia <[email protected]>
bcm2835_rust: 部分修正，尝试填充probe函数。 i2c mod: 添加i2c_bcm2835quirks。 device, platform, clk. Signed-off-by: Nostalgia <[email protected]>
bcm2835_rust: 部分修正，尝试填充probe函数。 i2c mod: 添加i2c_bcm2835quirks。 device, platform, clk. Signed-off-by: Nostalgia <[email protected]>
bcm2835_rust: 部分修正，尝试填充probe函数。 i2c mod: 添加i2c_bcm2835quirks。 device, platform, clk. Signed-off-by: Nostalgia <[email protected]>
creatoy
reviewed
Aug 4, 2024
rust/kernel/platform.rs
Outdated
There was a problem hiding this comment.
可以看下 platform.rs 里 Adapter 的 register 和 probe_callback 方法，利用它们也许可以自动将 i2c_adapter 要干的活做了，至少能做一部分
There was a problem hiding this comment.
我建议检查一下我之前的提交有没有出现修改c文件的情况，如果有就回滚一下，我怕我误操作了
rust/kernel/lib.rs
Outdated
| @@ -54,7 +54,7 @@ pub mod init; | |||
| pub mod io_buffer; | |||
| pub mod io_mem; | |||
| #[cfg(CONFIG_IOMMU_IO_PGTABLE)] | |||
| pub mod io_pgtable; | |||
There was a problem hiding this comment.
我这里显示找不到相关mod 可能又是无意间修改了什么不知道的 (悲）
There was a problem hiding this comment.
这里这个mod已经被上一行的cfg条件屏蔽掉了，不会引入并编译，不需要再注释了
可能是之前仓库遗留的一些东西
| pub fn kmalloc<T>(&self) -> Result<*mut T> { | ||
| let size = core::mem::size_of::<T>(); | ||
| let ptr = unsafe { | ||
| bindings::devm_kmalloc(self.ptr, size, bindings::GFP_KERNEL | bindings::__GFP_ZERO) |
There was a problem hiding this comment.
第三个参数是bindings里的，这里怎么做好？
There was a problem hiding this comment.
GFP的宏定义大多已经binding出来了，可以直接用。不过鉴于这个devm_kmalloc似乎没有什么地方用到，可以先不用封装它
bcm2835_rust: 部分修正，尝试填充probe函数。 i2c mod: 添加i2c_bcm2835quirks。 device, platform, clk. Signed-off-by: Nostalgia <[email protected]>
修正函数中数值及类型部分 Signed-off-by: Nostalgia <[email protected]>
修正函数中数值及类型部分，及所有权部分。 Signed-off-by: Nostalgia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.